Skip to content

Feat: LiteLlm: Make LiteLLM file attachment failures consistent by raising explicit errors instead of silent fallback#5547

Draft
Lin-Nikaido wants to merge 1 commit intogoogle:mainfrom
Lin-Nikaido:feat/litellm-attachment-failures
Draft

Feat: LiteLlm: Make LiteLLM file attachment failures consistent by raising explicit errors instead of silent fallback#5547
Lin-Nikaido wants to merge 1 commit intogoogle:mainfrom
Lin-Nikaido:feat/litellm-attachment-failures

Conversation

@Lin-Nikaido
Copy link
Copy Markdown
Contributor

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

Testing Plan

Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

Please include a summary of passed pytest results.

Manual End-to-End (E2E) Tests:

Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

@adk-bot adk-bot added the models [Component] Issues related to model support label Apr 29, 2026
@adk-bot
Copy link
Copy Markdown
Collaborator

adk-bot commented Apr 29, 2026

Response from ADK Triaging Agent

Hello @Lin-Nikaido, thank you for creating this PR!

Could you please fill out the Testing Plan section in your PR description? This should include details on how you tested your changes, such as unit test results or steps for manual end-to-end testing, as outlined in our contribution guidelines.

This information will help reviewers to review your PR more efficiently. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

models [Component] Issues related to model support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feat: LiteLlm: Make LiteLLM file attachment failures consistent by raising explicit errors instead of silent fallback

2 participants